Re:Writing serial port interrupt handler in linux
by srn on Tuesday October 20, 2009 @12:29PM
(#892653)
More explicit handling of error conditions is also good FWIW - don't see you doing it here. The kernel is not forgiving of using resources your don't have or failing to free resources acquired.
Re:Writing serial port interrupt handler in linux
by srn on Tuesday October 20, 2009 @12:32PM
(#892660)
Also from what I know, which is not much, you should be requesting the ports via request_region. If that fails you should probably not be writing to the ports and should also mean you're sharing the port with another module.
kernel newbies is theoretically a good place to go with these kinds of questions too.
I also would like to mention that in general memory barriers can be useful for working with i/o irrespective of your particular situation.