Spaced repetition is excellent for building vocabulary and learning new words. I'm less convinced of its effectiveness for more subtle things like grammar and sentence structure—those are the kinds of things that don't fit well on a flashcard. I'd say those things are more well-developed through deliberate practice and interactions with other speakers of the language.

I'll throw out a recommendation for Memrise (http://memrise.com) as well.