Re:Show HN: GitCop – Automated Commit Message Validation for...
by tokenrove on Monday November 10, 2014 @05:04PM
(#8586865)
I like the idea, but for projects that aren't open source, why not just mandate the use of a git commit-msg hook instead?
[ Parent
| on HN ]
Re:Show HN: GitCop – Automated Commit Message Validation for...
by Gazler on Monday November 10, 2014 @05:33PM
(#8587030)
A git hook would certainly work for this as you described and I would certainly encourage people to investigate that route if it is appropriate for them. http://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks
The goal for GitCop is to be fast and easy to set up in a way that integrates well into a GitHub pull request based flow.
Re:Show HN: GitCop – Automated Commit Message Validation for...
by rurounijones on Monday November 10, 2014 @07:04PM
(#8587472)
By that point isn't it too late? Or do you expect people to commit --amend and force push?
Re:Show HN: GitCop – Automated Commit Message Validation for...
by Gazler on Tuesday November 11, 2014 @03:42AM
(#8588903)
It is common in many flows to expect people to do a force push if something is wrong with their pull request, e.g. having 15 commits that look like:
Try stuff
Another prototype
Fix something
...
Revert prototype
It is fairly common (in my experience) for the contributor to be asked to squash those commits.In my opinion, the more guards in place the better.
Re:Show HN: GitCop – Automated Commit Message Validation for...
by dmethvin on Monday November 10, 2014 @09:12PM
(#8587891)
I think that's a key point, the earlier you can catch the problem the less frustrating for both sides. There is https://www.npmjs.org/package/commitplease for commit hooks but it's still handy to have something audit pull requests.