Show HN: EphChat – Ephemeral, Anonymous, Encrypted Realtime Chat

Re:Show HN: EphChat – Ephemeral, Anonymous, Encrypted Realti... by system_32 on Friday July 18, 2014 @10:14AM (#8053115)

You criticized about the random code generation function. Could you explain why it is bad? Though I code, I am no expert and would really like to know.

[ Parent | on HN ]

Re:Show HN: EphChat – Ephemeral, Anonymous, Encrypted Realti... by sarciszewski on Saturday July 19, 2014 @02:37AM (#8056874)

This is the offending code: https://github.com/bmmayer/ephchat/blob/ec375c7974ea825f887f...

This is the proper way to do it (h/t @tptacek): http://sockpuppet.org/blog/2014/02/25/safely-generate-random...

mt_srand() + rand() is just hilarious. The md5(uniquid()) thing is a common randomness anti-pattern in PHP projects that needs to die in a fire.

In PHP, a very brief example of the code to achieve the proper way of generating randomness looks like the snippet I posted in the issue.

[ Parent | on HN ]