News for hackers. Stuff that matters.
Re:Making code better with code reviews by matwood on Wednesday July 02, 2014 @08:59AM (#7976669)
Nitpicking should not be the point of a review, but would you consider it nitpicking to point out minor things that do not fall exactly in line with the current project standards? Naming is a big thing that comes to mind. Formatting is another.

Personally, when I review code I never look at it from an X or Y way, but from a current project way. I do not agree with how my current project does everything, but consistency is more important in a large code base until I can schedule time to change things I do not agree with across the entire code base.

To your specific case, someone who uses 3600 instead of making a constant probably has other magic numbers scattered about.

Also, remember the code that exists needs to serve as a guide for future programmers. The next programmer who comes in and sees 3600 now may think magic numbers are okay. So the minor thing you called a nitpick is picked up by someone else and made more of an issue, and so on.

There are no comments on this comment yet.