News for hackers. Stuff that matters.
Re:54-line if condition in gcc's reload.c by MaulingMonkey on Wednesday July 02, 2014 @02:29AM (#7975538)
> It's been getting the job done for decades, in perhaps the most popular compiler of all time. I'm willing to trust the maintainers' judgement on this one.

I don't trust anyone - myself included - writing code 1/10th as convoluted, age-of-product be damned. Code is not wine, old doesn't mean good. Neither do the maintainers, methinks: Looking at blame shows some refactoring.

> If they'd spent all their time needlessly refactoring, gcc would've gone the way of GNU/Hurd.

And the lack of needful refactoring may very well send it the way of COBOL - with everyone merely wishing it had gone the way of GNU/Hurd. I've seen clang and LLVM replace gcc in both of my vendor toolchains that used gcc - suggesting they've already wished and then done something about that wish.

(Either that or licensing, but code like this stomps on the scales a bit...)

Re:54-line if condition in gcc's reload.c by mackal on Wednesday July 02, 2014 @03:52AM (#7975724)
If you've read some of the other posts, this whole file will hopefully be removed sometime in the future. For x86/x86_64 this file isn't of any use.

Edit: also reading the wiki, they are fully aware how bad this code is.

Re:54-line if condition in gcc's reload.c by richardwhiuk on Wednesday July 02, 2014 @03:14AM (#7975631)
Old code is better - it's got bug fixes.
Re:54-line if condition in gcc's reload.c by MaulingMonkey on Wednesday July 02, 2014 @06:18AM (#7976079)
> Old code is better - it's got bug fixes.

It's also got prototypes that made it into production, ball of mud designs that encourage usage bugs, and C++ thrown together by that short lived intern who took a few Java classes, wrote everything assuming there was a garbage collector around, and took great care to avoid class trees with less than 3 layers of inheritance lest he be shamed for lack of 1337ness... then topped it off with a few __try/__catch blocks to deal with that one rare crash that nobody could find a repro case for.

Re-implementing bug fixes is a toll... sometimes a very worthwhile one, though.

Re:54-line if condition in gcc's reload.c by qu4z-2 on Wednesday July 02, 2014 @10:40PM (#7981180)
To be fair, new code frequently has those attributes too.