News for hackers. Stuff that matters.

A comment on Merge Pull Request Considered Harmful. Parent comment

Re:Merge Pull Request Considered Harmful by rlpb on Thursday June 26, 2014 @09:41AM (#7949544)
The right way to do this is to talk to the maintainer about how he wants the feature implemented first. Especially if it involves four weekends of work.
[ Parent | on HN ]
Re:Merge Pull Request Considered Harmful by aResponder51 on Thursday June 26, 2014 @10:20AM (#7949736)
Depends on the size of the feature, and the maintainer, but you're right about "talk to the maintainter."

Some projects, you'll want to do a weekend of really rough work, contact the maintainer, get their thoughts. Others, you'll want to do 8 days work, get it far enough along to show, get their thoughts.

Often though, before you write a line of code, talk to them.

[ Parent | on HN ]
Re:Merge Pull Request Considered Harmful by rjbwork on Thursday June 26, 2014 @02:25PM (#7950911)
We did, he explained it, then implemented it himself, and it was a bug-ridden, memory-leaking piece of shit that isn't merged in either.
[ Parent | on HN ]