News for hackers. Stuff that matters.
Re:Massive Twitter Cross-Site Scripting Vulnerability by al3x on Tuesday August 25, 2009 @07:00PM (#786098)
See my other comment. The engineer who wrote this code did take the time to validate, but his validation was incorrect.

Call it "blatant incompetence" if you like, but I'm guessing you've written a buggy validation or regex once or twice in your life.

Re:Massive Twitter Cross-Site Scripting Vulnerability by blasdel on Tuesday August 25, 2009 @09:06PM (#786280)
Except that using validation at all in this case is a mistake, especially writing it yourself for a narrow case, much less using regexes to do it.

Escaping, damnit.

Re:Massive Twitter Cross-Site Scripting Vulnerability by al3x on Wednesday August 26, 2009 @12:43AM (#786584)
Yes, I agree. That's why we've tried to assist Rails Core in reviewing a more comprehensive string tainting model. I've said for some time now that security needs to be institutionalized in frameworks in order for developers to be unable to make stupid mistakes like this one.
Re:Massive Twitter Cross-Site Scripting Vulnerability by lallysingh on Wednesday August 26, 2009 @04:57AM (#786864)
If that's bad, remember the old iTunes installer bug?

http://apple.slashdot.org/article.pl?sid=01/11/04/0412209...

They had a shell script which didn't "quote" their $variables. It rm -rf'd entire drives by mistake. It's why I use "$@" now.

Re:Massive Twitter Cross-Site Scripting Vulnerability by idlewords on Tuesday August 25, 2009 @07:12PM (#786122)
So you let the same engineer who writes code green-light it for deployment?
Re:Massive Twitter Cross-Site Scripting Vulnerability by al3x on Tuesday August 25, 2009 @07:36PM (#786150)
No. We have a code review process. It wasn't caught in review, and was okayed for deployment by another engineer.