News for hackers. Stuff that matters.

A comment on On Pull Requests. Parent comment

Re:On Pull Requests by entropy_ on Monday May 05, 2014 @09:04AM (#7698291)
You don't need to force push at all. You could just apply the changes to your PR in a different branch(completely local, rewrite history as much as you want, etc, etc) and then submit a second PR with that.
[ Parent | on HN ]
Re:On Pull Requests by davexunit on Monday May 05, 2014 @09:27AM (#7698412)
A whole new PR? That just shows how broken PRs are if that's the solution to this problem.
[ Parent | on HN ]
Re:On Pull Requests by jimktrains2 on Monday May 05, 2014 @07:41PM (#7702020)
It's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.
[ Parent | on HN ]
Re:On Pull Requests by davexunit on Tuesday May 06, 2014 @11:26AM (#7705034)
There's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.
[ Parent | on HN ]