Nginx SPDY heap buffer overflow (affects 1.3.15

Re:Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11) by jxf on Tuesday March 18, 2014 @08:20PM (#7426046)

Why was it replaced with "#if 1" instead of just deleting the entire "if/end" delimiters? Won't that always evaluate to true?

[ Parent | on HN ]

Re:Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11) by mherkender on Wednesday March 19, 2014 @12:51AM (#7426884)

Maybe they wanted a patch that could be easily applied to older versions. It might have an elif later too, although I'm guessing that's not too common after debug blocks.

[ Parent | on HN ]

Re:Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11) by citrin_ru on Wednesday March 19, 2014 @10:45AM (#7428918)

To keep patch small. Now #if 1 is removed: http://hg.nginx.org/nginx/rev/b93db4e4ff77

[ Parent | on HN ]