Re:GitHub's language detection is broken
by DangerousPie on Friday March 14, 2014 @08:59AM
(#7398411)
I bet it's not as easy as "just delete the code". They will probably have to do quite a bit of refactoring to remove this, followed by a probably even larger amount of testing.
Long-term this is probably the right solution, but why go through all this trouble right now if there is a simple workaround? It seems like the only problem right now is a few people's pride.
Re:GitHub's language detection is broken
by moron4hire on Friday March 14, 2014 @09:17AM
(#7398491)
Of course it's not that easy. They don't have a compiler with a static checker to show them all the places the field was used :P
Re:GitHub's language detection is broken
by Allan_Smithee on Friday March 14, 2014 @09:17AM
(#7398492)
How much you wanna bet? (https://github.com/github/linguist/issues/985)
Re:GitHub's language detection is broken
by DangerousPie on Friday March 14, 2014 @10:13AM
(#7398815)
If I'm reading this right all this does is define the first extension as the primary extension, which still has to be unique. So they would still have to use a different extension as the first one in the list, it just wouldn't be called "primary" anymore. How would this help?
There is no unicity check anymore; I just kept the first one special because some private code at GitHub seems to rely on the primary_extension property for the Gist editor. As I can't hack this (it is private), I can't remove it entirely.
At worst, it is confusing to implementers and requires chicanery to work around... which is exactly the case we're in. We're in the worst case scenario for this bit of code, and there is no upside to its best-case scenario. Just delete the code.