Re:How to be a faster code reviewer
by matwood on Thursday March 06, 2014 @04:00PM
(#7356549)
My biggest pet peeve when I send code out for review is someone responding with the superficial bullshit stuff
Send something out with a fairly complex algo and you get back people complaining about a brace being 2 spaces instead of 4 or something else that will be automatically cleaned up by your editor before commit.
Re:How to be a faster code reviewer
by jakub_g on Thursday March 06, 2014 @04:35PM
(#7356778)
You should have an automatic code formatter / checker if possible. Plus code linter. Automate everything if possible and make build fail in case of discrepancies. Then there'll be no discussions like that.
Send something out with a fairly complex algo and you get back people complaining about a brace being 2 spaces instead of 4 or something else that will be automatically cleaned up by your editor before commit.