Re:How to be a faster code reviewer
by dragonwriter on Thursday March 06, 2014 @01:25PM
(#7355581)
> Have others gone through this, and if so, how would you recommend 'teaching' a newer coder how to do quality code reviews of the elder coders around him?
One approach might be this rule: "If you don't understand, get an explanation from whoever it came from until you do understand."
If there's a more-senior reviewer available, you might have them come along for the discussion to ask additional questions as necessary, but the main focus should be getting the original developer to explain their reasoning to the junior reviewer.
Re:How to be a faster code reviewer
by dllthomas on Thursday March 06, 2014 @01:28PM
(#7355595)
Very much so. Either it's a bug, it's not written clearly, or you have something to learn. Any which way it's a problem, and asking about it is the way to fix it.
One approach might be this rule: "If you don't understand, get an explanation from whoever it came from until you do understand."
If there's a more-senior reviewer available, you might have them come along for the discussion to ask additional questions as necessary, but the main focus should be getting the original developer to explain their reasoning to the junior reviewer.