Every story and comment from the Hacker News API, in a layout borrowed from 2001.
A comment on Why was "goto fail;" added without any other change to that part of the code?.
@@ -198,10 +198,8 @@ sslDebugLog("SSLEncodeRSAKeyParams: modulus len=%ld, exponent len=%ld\n", modulusLength, exponentLength); OSStatus err; - if ((err = SSLAllocBuffer(keyParams, - modulusLength + exponentLength + 4)) != 0) { - CFReleaseSafe(exponent); - CFReleaseSafe(modulus); + if ((err = SSLAllocBuffer(keyParams, + modulusLength + exponentLength + 4, ctx)) != 0) { return err; } uint8_t *charPtr = keyParams->data;
This is why you use goto fail and not early returns.
There are no comments on this comment yet.
This is why you use goto fail and not early returns.