News for hackers. Stuff that matters.
Re:People in your organization that grow legacy code by mseebach on Monday February 24, 2014 @09:33AM (#7290938)
1: Should have used a library function

2: not 0-indexed (there can be good reasons for this, but the context of the function should at least suggest the reason)

3: Doesn't handle errors - should throw IllegalArgumentException, and if should do it in the default handler of the switch. If you suddenly see "???" in the UI, it's not easy to track down to this.

4: If for some valid reason this can't be a library function, it should be an enum, and it should be used throughout the code.

    enum DayOfWeek {
       MONDAY(1, "Monday"), TUESDAY(2, "Tuesday") ...

       public int id;
       public String displayName;  // these should be private and have getters according to most style-guides.

       public DayOfWeek(int id, String displayName) {
           this.id = id;
           this.displayName = displayName;
       }

       public static DayOfWeek fromId(int id) {
           for (DayOfWeek d : values()) {
               if (d.id == id) return d;
           }
           throw new IllegalArgumentException("Illegal DayOfWeek id passed: " + id);
       }
    }
Re:People in your organization that grow legacy code by ygra on Monday February 24, 2014 @09:37AM (#7290966)
FWIW, the default Java API to get weekday strings is also 1-based (DateFormatSymbols.getWeekdays(); and Calendar.SUNDAY is 1).
Re:People in your organization that grow legacy code by anton_gogolev on Monday February 24, 2014 @09:51AM (#7291048)
Yeah, with Java DateTime API being royally fubarred [1].

[1]: http://stackoverflow.com/q/1969442/60188

Re:People in your organization that grow legacy code by melignus on Monday February 24, 2014 @10:41AM (#7291342)
... every DateTime API ...

FTFY

Re:People in your organization that grow legacy code by a3voices on Monday February 24, 2014 @10:21AM (#7291228)
In iOS, days aren't 0 indexed either by default. Sunday starts at one.