Re:Code Reviews and Bad Habits
by willismichael on Thursday February 20, 2014 @11:56AM
(#7271883)
For what it's worth, Review Board has a way to visualize multiple revisions in a single code review request. I think it is primarily intended for the patch writer and reviewers to go back-and-forth (like "ok, here's my fix based on you comments"), but with some scripting you could make your own tool that uploads a whole series of revisions to Review Board.
[ Parent
| on HN ]
One of our contributors has recently done exactly this, triggered by a `git push`:
Announcement: https://groups.google.com/d/msg/reviewboard/SVOF-4KZ-VU/lSf0...
Video: http://vimeo.com/86448355
Also, for the record, after we wrap up this 2.0 release, we'll be focusing on allowing users to review branches of commits in a review request, and not just individual squashed patches.
I wrote a tool we use internally that has that as a feature for Review Board. It was super easy.
I still prefer a more formal code review process since things slip through from people hitting "Ship It" when it's not fully baked.