Re:Guide to Advanced Programming in C
by deletes on Thursday February 06, 2014 @06:52PM
(#7193769)
How does this check for anything??:
size is not given a type, but if it is a size_t, then the comparison is constant and if statements is always false, unless size == 0. The second part is useless, since the maximum size of size_t == SIZE_MAX.
[ Parent
| on HN ]
Worse, it is not even a certain check against integer overflow. A particularly large expression could have overflowed substantially enough that it becomes positive again!
This, in fact, was the source of a vulnerability in PHP [1]. (The way they 'resolved' it, uh, isn't much better.)
There is almost never a magic bullet for integer overflow. Programming secure systems requires thought.
[1] http://use.perl.org/use.perl.org/_Aristotle/journal/33448.ht...
Note that since it says 'size == 0', it's not merely "not a certain check", but a check that passes for almost all overflowing values :)
Hmmm, that looks oddly familiar: http://use.perl.org/use.perl.org/_Aristotle/journal/33448.ht...