Re:Managing Node.js Callback Hell with Promises, Generators ...
by inglor on Tuesday February 04, 2014 @03:03PM
(#7179903)
rtdsc:
> Was that addressed to strongloop.com? They are the ones that posted an example with promises using 27+/-whitespace lines of code and the initial problem algorithm only had 4 lines.
Oh wow, this is my fault, I didn't read what they did there. I have __no idea__ why it took them 27 lines to implement this. It's rather trivial with promises.
- They have a .then followed by a .map there causing nesting for no reason whatsoever.
- They also get the file name, but handle this very poorly (with an array), where they could just do it as a part of the .map (the .all and .then are completely redundant) there
- They assume the possibility of directories, I didn't. That .filter is justified but that's the only thing one might have to add here.
- Generally, it's poor promise code.
I guess that promises are just not their tools of choice and they just used them _for that post_.
Was that addressed to strongloop.com? They are the ones that posted an example with promises using 27+/-whitespace lines of code and the initial problem algorithm only had 4 lines.
Sounds like you should write a blog post and not them about using promises.
I don't use Node.js on daily basis and am not familiar with promises so just commented as an outsider based on the article.
Your last one line looks fantastic and makes it clear what is going on. Any reason you can think of why that wasn't the "obvious" solution to the original posters of the article?