News for hackers. Stuff that matters.
Re:Trust but Verify by xtrumanx on Sunday January 12, 2014 @11:16AM (#7046340)
> and anyway Mozilla committers regularly check in code which doesn't match the reviewed code

How does that work? Are reviews optional?

Re:Trust but Verify by samth on Sunday January 12, 2014 @01:18PM (#7046830)
It works because a reviewer will say "here are a bunch of comments, the patch is approved once these are fixed". It's a very reasonable thing to say when the comments are minor (such a style issues) and the reviewer and coder trust each other.
Re:Trust but Verify by BrendanEich on Sunday January 12, 2014 @01:17PM (#7046816)
Reviews are required, but we don't have automation to test integrity and authenticity. Mostly the diffs between what is reviewed and what is pushed are cosmetics that the reviewer asked for and pre-r+'ed without wanting another patch in a bug, but there's room for mischief.

People do watch bugs and repos and catch stuff. We are working on making the system more foolproof, as part of a larger effort to move all our CI infra (save Mac, sigh) to the cloud and our release engineering to a devops model.

Re:Trust but Verify by reubenmorais on Sunday January 12, 2014 @05:55PM (#7047846)
>(save Mac, sigh)

Bug 921040 [0] seems to be progressing, even if slowly.

https://bugzilla.mozilla.org/show_bug.cgi?id=921040

Re:Trust but Verify by BrendanEich on Sunday January 12, 2014 @08:21PM (#7048300)
Yeah, I am not holding my breath. If the tremendous effort there pays off and Apple doesn't screw us later, yay.

/be