I would not be surprised for research to demonstrate that children perform to the expectations given them, particularly when those expectations are clear and consistent. In fact, most people thrive in environments where they understand the rules, rewards, penalties, and where those structures are evenly and consistently enforced.
Correcting mistakes is one thing but insulting people making errors is probably harmful not helpful.
It's cliche because there's some merit: he wasn't our friend, but had an incredibly positive effect on our abilities in the subject.
I've no strong opinion whether public shaming is good or bad with spelling errors. Maybe the hypersensitivity we've culturally adopted to the emotional state of children biases our perception of the impact of such things.
But it worked, the newspaper and yearbook were consistently the best in the country. It wasn't just a niche club, they were actually credit classes that filled up. It was actually cool* to be on staff, despite how seriously it was taken (though thinking back, my main contribution was installing NES emulators on all the machines, so it couldn't have been that serious)...
Edit: to clarify, I can't recall if he "ripped" into people for spelling errors/grammatical mistakes, though he'd point them out in a funny way and move on. But boy, if you did something like a professional breach...such as interview your same best friend for an article that you did last month, he might go off on it. Sloppy writing (burying the lede) was also jumped on, but in a constructive way. But that kind of constructive criticism...singling someone out in class...I didn't see it much out of high school.