Re:Communication? Check
by indirect on Monday December 02, 2013 @03:47AM
(#6832547)
I used to work at a shop that used Gerrit[1] to manage our master branch. Pushes directly to master were rejected, and all commits had to be signed off by a developer other than the author, confirming that a) the tests passed and b) the functionality had changed as advertised.
Motivation to review started low but got quite high once developers wanted their own code merged. Motivation to merge other things without checking started high, but got low extremely quickly once the merger had to fix the tests if they merged a failure.
I sometimes wonder if it's somehow possible to get either one of those (extremely positive) trends in a "modern" github-based workflow.
Re:Communication? Check
by raganwald on Monday December 02, 2013 @08:42AM
(#6833527)
I work in an environment like this now, and it's fine, because we have a review culture. I don't think that technology can every impose a cultural shift by itself.
Motivation to review started low but got quite high once developers wanted their own code merged. Motivation to merge other things without checking started high, but got low extremely quickly once the merger had to fix the tests if they merged a failure.
I sometimes wonder if it's somehow possible to get either one of those (extremely positive) trends in a "modern" github-based workflow.
1: https://code.google.com/p/gerrit/