News for hackers. Stuff that matters.

A comment on Collaboration not Derision in the Node Community. Parent comment

Re:Collaboration not Derision in the Node Community by itafroma on Saturday November 30, 2013 @11:46PM (#6826159)
I couldn't find any explicit statement by Noordhuis that could be characterized as what Cantrill called an "insistence that pronouns should in fact be gendered". I took that to be something Cantrill thought was implied by the revert.

However, there's a deleted GitHub comment from Noordhuis that nevertheless still appears on his public activity stream[1]. I starts with:

> For the record, I reverted the merge in 804d40e. Isaac may be a committer but that does not mean he is free to land patches at will. Patches have t…

Perhaps it was stated there?

[1]: https://github.com/bnoordhuis?tab=activity

[ Parent | on HN ]
Re:Collaboration not Derision in the Node Community by GrinningFool on Sunday December 01, 2013 @12:43AM (#6826297)
Seems not: https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...

Ultimately, it looks like Ben was fairly impartial about the whole thing - he didn't accept it because it wasn't a significant enough change to merit accepting. He tried to revert the acceptance because the acceptance had been done without approval.

[ Parent | on HN ]
Re:Collaboration not Derision in the Node Community by Lazare on Sunday December 01, 2013 @01:08AM (#6826345)
Technically, he was in the right.

Politically, reverting Isaac's commit (and especially doing so with a passive aggressive "Isaac, consider yourself chided." commit message) was clearly a mistake.

[ Parent | on HN ]
Re:Collaboration not Derision in the Node Community by GrinningFool on Sunday December 01, 2013 @12:29PM (#6828199)
A mistake, but only in context of the larger issue. In the context of a reverted commit, it was a fairly laid-back way of saying "you shouldn't have done this direct merge and you probably knew better".
[ Parent | on HN ]