Re:Libsass – C implementation of a Sass compiler
by mhogomchungu on Monday November 25, 2013 @09:31PM
(#6798712)
a bit of optimization in $src/libsass/copy_c_str.cpp
[ Parent
| on HN ]
Re:Libsass – C implementation of a Sass compiler
by unwind on Tuesday November 26, 2013 @03:24AM
(#6799895)
Uh, okay. I didn't read the original, sounds somewhat scary.
Anyway, please don't cast the return value of malloc() in C (http://stackoverflow.com/a/605858/28169).
Also, of course len should be const and sizeof (char) should be removed. Also testing whether malloc() succeeded before relying on the result being valid is a good idea (but perhaps there's machinery in place to abort on error), as is deciding what to do if the input string is NULL.
Re:Libsass – C implementation of a Sass compiler
by dchest on Tuesday November 26, 2013 @04:55AM
(#6800201)
Anyway, please don't cast the return value of malloc() in C (http://stackoverflow.com/a/605858/28169).
It's C++.
Re:Libsass – C implementation of a Sass compiler
by stevekemp on Tuesday November 26, 2013 @04:07AM
(#6800073)
Wouldn't this be even better:
return( strdup( orig ) );
?
Re:Libsass – C implementation of a Sass compiler
by mtklein on Monday November 25, 2013 @09:39PM
(#6798746)
or maybe just
#define copy_c_str strdup
?
Re:Libsass – C implementation of a Sass compiler
by akhleung on Monday November 25, 2013 @09:39PM
(#6798745)
Thanks, I'll give it a try and benchmark it. Also, pull requests are welcome for this sort of thing!
[deleted]