News for hackers. Stuff that matters.

A comment on We don’t have time for code reviews. Parent comment

Re:We don’t have time for code reviews by jt2190 on Wednesday October 23, 2013 @11:47AM (#6599432) 

    > Sometimes it may take me a day or more to fully get 
    > my head around a new piece of code I am working with.
Are you trying to perform a design review, or a code review? Code reviews (in my mind, at least) concern themselves with the low-level mechanics of the code ("Handle this exception properly","there's a library method for this logic","follow the team's coding standards", etc.) whereas design reviews deal with the "how is this thing supposed to work?". When reviewing code, I avoid dealing with design issues. If I see design issues, I ask the developer for a design review.
[ Parent | on HN ]
Re:We don’t have time for code reviews by mberning on Wednesday October 23, 2013 @03:24PM (#6601062)
My time is more valuable than being a pre-compile/pre-deploy sanity check or human lint.

When I review code I review all of it, not just the easy parts.

If I was going to do a 1/2 ass job of it I wouldn't do it in the first place.

[ Parent | on HN ]
Re:We don’t have time for code reviews by jt2190 on Thursday October 24, 2013 @01:33PM (#6606616) 

  > When I review code I review all of it...
We haven't mentioned timing, but that's the reason I decouple design and code reviews.

Design reviews can be done fairly early in the process before the code is complete. If design changes are needed, there is still plenty of time for them.

Code reviews can't really be done until most of the code is written, but (as you point out) the kinds of problems they find are much easier to fix, so require less time.

[ Parent | on HN ]