News for hackers. Stuff that matters.

A comment on We don’t have time for code reviews. Parent comment

Re:We don’t have time for code reviews by jchendy on Wednesday October 23, 2013 @10:15AM (#6598840)
Are code reviews by non-programmers actually common? How can that possibly work?
[ Parent | on HN ]
Re:We don’t have time for code reviews by ohwp on Wednesday October 23, 2013 @10:22AM (#6598887)
I've seen 'code reviews' that were in fact functionality checks. So it's more like a 'check if this code works'.

And I can tell you: a web form capable of SQL-injections is still 'working code'. So it gets a positive 'code review'.

[ Parent | on HN ]
Re:We don’t have time for code reviews by masklinn on Wednesday October 23, 2013 @10:40AM (#6598995)
Sounds like there's no code being reviewed, how can it be called "code review"?
[ Parent | on HN ]
Re:We don’t have time for code reviews by trevor_oke on Wednesday October 23, 2013 @01:29PM (#6600220)
That's not a code review; that's either QA or UAT.
[ Parent | on HN ]
Re:We don’t have time for code reviews by ryanto on Wednesday October 23, 2013 @10:44AM (#6599027)
Bots that scan code for syntax/quality. While these are useful they should not qualify as a complete code review.
[ Parent | on HN ]