Re:We don’t have time for code reviews
by benihana on Wednesday October 23, 2013 @09:56AM
(#6598736)
I think it's hilarious (and typical) that the moral of the story is "I don't push without code reviews" not "I don't use bad words in test code."
[ Parent
| on HN ]
"I don't use bad words in test code."
This is actually really important. We had this happen with a customer whilst UAT testing. The project schedules were under pressure and as a result the customer went nuts (rightly so) and we had to make some concessions to customer as amends.It isn't just curse / bad words. Equally as bad are comments like:
"this was the customer's stupid idea not ours"
Also, if you really have to output test stuff in the browser use console.log('message') and not alert('message').Then for production you can always do this at the top of your main JavaScript include:
var console = {};
console.log = function(){};
Re:We don’t have time for code reviews
by xymostech on Wednesday October 23, 2013 @11:17AM
(#6599228)
What about
window.alert = function(){};
Re:We don’t have time for code reviews
by jcromartie on Wednesday October 23, 2013 @10:11AM
(#6598812)
Professionalism is for people who wear shirts with collars and have nice cars and families. You know, the kind of people who fund the kind of place where you can use bad words in code...