As a point of fact, the article writer's positions on Obama and McCain that he discusses in the text were to win the nomination, not the general election. He would have won the McCain bet with the full dollar if he had hung on to it.
You can read the raw data, less ambiguous than the text, below the main article.
the article writer's positions on Obama and McCain that he discusses in the text were to win the nomination, not the general election
You're right, and I hadn't grasped that from the article. See my response to the article's author upthread.
The example of the McCain bets for the 2008 election is a case in point: if the author's bet would only have paid off on the actual outcome, he would have lost! The only reason he was able to make money at all was that he found other people willing to buy his bets.
Similarly, in your asteroid example, yes, you sold your bets because information changed, but the reason you were able to make money doing so was that there were other people willing to buy your bets--which means their expectations about the outcome must have been different from yours (if they were the same as yours, no one would buy your bet, because the trade is zero sum). So you are making money based on others' beliefs about the outcome, not based on the actual outcome.
For example, if the asteroid ultimately does not hit, then all your "yes" bets are losing bets; the only reason you made money was that you sold your bets before the fact that they were losing bets became known for certain, just like the article's author did with his McCain bets. But also, even if the asteroid ultimately does hit, your payoff doesn't depend on that, because you sold your bets; someone else, who bought them, ended up making the profit you could have made if you had held them until the outcome was known. So once again, you made your money based on other people's beliefs about the outcome, not based on the actual outcome. (You even agree with this, when you say that you sell when the market odds are close to your own beliefs: the market odds are determined by the average beliefs of all the participants, not by the actual outcome.)