Re:Surespot app - free and open source encryption for everyone
by bazzargh on Monday September 02, 2013 @04:42AM
(#6314115)
Just thinking about that - this class of error gets reported by Findbugs and other static analysis tools. So, this bug indicates that there aren't tools like that in the build - for a security app, where correctness should be top priority, that's surprising.
Re:Surespot app - free and open source encryption for everyone
by bazzargh on Tuesday September 03, 2013 @09:35AM
(#6320830)
So I raised an issue with Surespot, and it is indeed the case that Android uses UTF-8 everywhere by default, independent of locale (much more sensible than Sun's Java!). The code is correct. Nothing to see here, move along.
https://github.com/surespot/android/blob/master/src/com/twof...
...but someone making a mistake with getBytes() usually does it everywhere.