News for hackers. Stuff that matters.
Re:SQL Injection Galore by foogs on Monday August 05, 2013 @09:26AM (#6159923)
my 2 cents: 1) At the first place, yes, it does look like these are sureshot SQL injections. 2) However, we are looking through just a tiny window. There could be filter chains executed long before this code that would sanitize the request parameters before they are consumed anywhere else in the codebase.
Re:SQL Injection Galore by dwrowe on Monday August 05, 2013 @11:34AM (#6160704)
It is a small window, however, wouldn't it be better to filter the values into an easily identifiable 'clean' variable? The code is still using $_GET, and while it may have been filtered above me, I have no indication of that - versus - $foo->cleaned('var') - where I can reasonably assume it is clean.
Re:SQL Injection Galore by foogs on Monday August 05, 2013 @01:41PM (#6161544)
True, I couldnt agree more