News for hackers. Stuff that matters.
Re:GitHub's on your phone by kevin1024 on Monday July 15, 2013 @05:14PM (#6048585)
Interesting that they decided not to do a responsive design. Instead, it serves up different HTML if you send a phone user-agent. I've been trying to decide if this is a good idea for my own project.
Re:GitHub's on your phone by holman on Monday July 15, 2013 @05:20PM (#6048606)
For us, it made sense.

Our desktop site is pretty large. Check the graph in the blog post- the mobile pages are about 1/10th the size of the desktop CSS and JavaScript. By avoiding a responsive design, we can make things load disproportionately faster for our use case. On top of that, it's isolated so we're less likely to break views by adding features later. Pretty fun.

Re:GitHub's on your phone by daegloe on Monday July 15, 2013 @05:25PM (#6048640)
Zach, what was the reasoning behind using such large text for the code view? Will there be a zoom in/out option? Or a text size preference?
Re:GitHub's on your phone by holman on Monday July 15, 2013 @05:32PM (#6048673)
To make it easy to read code. :) It feels pretty comfortable- squinting isn't fun.

We tend to avoid user preferences. If it ends up being a problem, we'll lower the text size at some point.

Re:GitHub's on your phone by xnxn on Monday July 15, 2013 @06:01PM (#6048826)
It seems a bit extreme on my Nexus 4... http://i.imgur.com/hagaiLR.png
Re:GitHub's on your phone by Stratoscope on Tuesday July 16, 2013 @12:09AM (#6049972)
I'm old and I like big fonts. But on my Galaxy Note II, this is too big for me.

I like word wrap too, but I'd like to be able to switch it off. In my desktop code editors, I generally use proportional fonts and enable word wrap, but sometimes I also like to be able to see the structure of the code without the word wrap.

I think font size and word wrap should be things that are easy to toggle right there while you're looking at the code. Not in an option setting somewhere. Or enable pinch-zoom for the font size and just have an option to toggle word wrap.

Re:GitHub's on your phone by ville on Monday July 15, 2013 @06:05PM (#6048854)
Speaking of the code view, any plans on adding code commenting capability on mobile? This has been a bit difficult to use on a phone because the click target is so small on the desktop version.

I can't resist doing code reviews even when I'm away from keyboard :)

Re:GitHub's on your phone by charliepark on Monday July 15, 2013 @07:11PM (#6049110)
Congrats to you and the team on launching this.

I'd love to know the technical approach on this. That is, is the different HTML/CSS/JS view called by the Rails controller, based on the request's user agent? Though responsive designs are often a good call, I completely agree with your decision to do custom views here. I'd love to know where in the process the filtering happens, though, such that you retain the URLs (no "m.github.com") and yet have the customized view. Any backstory on the technical aspects that you can share?

Re:GitHub's on your phone by ludwigvan on Monday July 15, 2013 @11:53PM (#6049938)
Re:GitHub's on your phone by talles on Monday July 15, 2013 @05:22PM (#6048618)
I'm not that experience with responsive design, but recently I wondered that myself and, for what I saw, I concluded that is too much effort to make it responsive in that level.

Responsive feels great with huge/big/medium displays. With tiny ones I would go with a specific layout (like github did).

Re:GitHub's on your phone by foca on Monday July 15, 2013 @05:24PM (#6048631)
Yeah, it definitely depends on the use case. Some websites just "make sense" on responsive layouts. Others… not so much :)
Re:GitHub's on your phone by Spiritus on Monday July 15, 2013 @05:20PM (#6048607)
Well I guess it's because that gives them the ability to slim down the page size even more, you can only get so far with CSS media queries.