Re:In 8 months at Microsoft, I learned these things
by cobrausn on Wednesday June 12, 2013 @04:22PM
(#5870480)
Where did he mention poor code quality? Out of date documentation is all I see mentioned.
[ Parent
| on HN ]
Re:In 8 months at Microsoft, I learned these things
by myko on Wednesday June 12, 2013 @06:07PM
(#5871060)
He mentioned copy/pasting code and skipping reviews were popular things to do. The first one is definitely a sign of poor code quality, and the second isn't as definite but is surely a practice that makes room for poor code quality.
Re:In 8 months at Microsoft, I learned these things
by Draiken on Wednesday June 12, 2013 @04:57PM
(#5870686)
I'd say that's implicit, if code that doesn't deliver business value (refactoring, documenting, etc.) is wasted, people won't do it.
Re:In 8 months at Microsoft, I learned these things
by seanmcdirmid on Wednesday June 12, 2013 @05:56PM
(#5871003)
I don't think code quality and documentation quality are strongly correlated, they are just complementary.
Re:In 8 months at Microsoft, I learned these things
by Draiken on Thursday June 13, 2013 @09:18AM
(#5873860)
I'd say without documentation any code loses quality.
I'm not talking about giving a manual for every piece of code you write, but any code that will be used by others (specially in big companies) should be well documented.
If good code is not documented, it will probably cause the same amount of trouble for people using it, than a bad piece of code.
People often forget that their code normally ends up outliving them.
Re:In 8 months at Microsoft, I learned these things
by seanmcdirmid on Thursday June 13, 2013 @07:45PM
(#5877407)
People also often forget that a lot of code doesn't survive the week, which is common in an agile setting. Documenting code is something you do when you know it can live for awhile.
Also, if the focus is on maintainability, the person documenting the code shouldn't be the same person who wrote it, who already has biases on what is obvious or not. Rather, it should be someone with access to the author(s) who can ask questions and document what they didn't get right away.