News for hackers. Stuff that matters.
Re:Analyzing mbostock's queue.js by goblin89 on Monday April 01, 2013 @07:25AM (#5472408)
IMO any overly clever code would remind of obfuscation. The trick is to notice in time your own attempts at being smart and refrain. Thus the code could communicate most of the things that needed to be explained in this walkthrough.

That's also why I personally am not very enthusiastic about such code reviews. Good code would seem boring, and why study bad code?

Re:Analyzing mbostock's queue.js by pekk on Monday April 01, 2013 @10:43AM (#5473304)
Aren't code reviews normally meant to highlight which parts are good and which are bad?
Re:Analyzing mbostock's queue.js by goblin89 on Monday April 01, 2013 @10:57AM (#5473405)
Not in this case, though—OP just explains what does the code do, without any opinion.
Re:Analyzing mbostock's queue.js by atomical on Monday April 01, 2013 @08:16AM (#5472569)
So you become a better programmer?
Re:Analyzing mbostock's queue.js by goblin89 on Monday April 01, 2013 @10:50AM (#5473360)
Fair enough, maybe it would work for someone. I find that reading and especially writing code of certain style shapes my style accordingly, similar to how our environment influences us, so I'd rather learn by working with good code—but it's just me.
Re:Analyzing mbostock's queue.js by atomical on Tuesday April 02, 2013 @06:27AM (#5478496)
Code reviews are about finding (1) the proper way to do things (2) edge cases, bugs, and the right architecture. Code reviews are not academic at all. They do require someone with a lot of experience.