News for hackers. Stuff that matters.
Re:80 chars per line is great by thangalin on Monday March 25, 2013 @01:31PM (#5438316)
The code is illegible for a number of reasons:

* Duplication everywhere.

* No internal comments indicating the code's purpose.

* Long functions with too much nesting.

* Lack of constants.

* Indenting by 4 spaces (instead of 2).

* Lines like 316-320 and 326-335 should line break and indent after the first open parenthesis to avoid huge whitespace.

* Inconsistent line break usages for long lines.

* Line 412, for example, should line break at "ref_pos".

The code has many shortcomings, including readability due to extreme line length.

There are no comments on this comment yet.