I believe that the reason that Amazon does this (I have an account) was intended to get around the sales tax issue by calling the payments for advertising as opposed to something that a State could take as "reseller" and translate to a presence and have a stronger leg for state sales tax from Amazon (not relevant given the recent changes but it was back when this practice started).
Sound about right?
But what I see a bigger problem is that her asking for donation is presented to the reader as something which keeps the site ad-free, while it seems to be just another revenue stream.
Oddly, I don't like affiliate links in forums like HN.
No, I think that's a sidetrack. The issue, at least how I read it, is saying to the dear reader "please donate as that's my only income source"* when it's not true. It's deliberately deceptive.
What's odd is that there's nothing wrong, that I can see, with just being upfront about affiliate links - "Hey, want to support this blog? I get a small amount of money from any purchases made by clicking on the amazon links"
* Yes, I realise that's not the words she's using, but it sure is the message that's conveyed
This is rarely attempted in a world of publications that depend on ad volume and outsourced ad buyer supply, but examples exist. The webcomic Penny Arcade recently ran a Kickstarter to achieve freedom from ads, but found itself answering questions like "What if I love ads?" (http://www.penny-arcade.com/2012/07/20/what-if-i-love-ads) because they'd built a reputation of only advertising products they would feel comfortable endorsing even without an adbuy (can't find a direct link to when they talk about this, but it's out there somewhere).
You don't say your site is ad-free if you get paid for links. Especially inside the donations pitch.
I don't care if you take donations, have a paywall, or sell advertisements (the ballet does all three, and that's awesome). Just be honest.
A maxim I use when trying to establish honesty: If you write a sentence that a substantial number of readers are misinterpreting, it's usually fair to call it an inaccurate sentence. If it's knowingly left there, it's usually fair to call it dishonest. Exceptions would include technically difficult material.
Edit: In this case, both the group paying her (Amazon) and Wikipedia refer to affiliate links as ads. I haven't polled her general readership, but that's a reasonable proxy for how the terms "ad-free" and "affiliate links" are interpreted.
https://affiliate-program.amazon.com/ http://en.wikipedia.org/wiki/Affiliate_marketing