News for hackers. Stuff that matters.
Re:GitHub New pull request overview page in public preview by bob1029 on Sunday November 08, 2026 @02:57AM (#50411272)
I don't get all the people who complain about reviewing PRs. To me being a critic is much less stressful than being the author. Perhaps so much so that it becomes borderline enjoyable.

35 PRs on my client's codebase would be no big deal because I took a lot of time to understand the fundamentals of the business around it. I can recognize within seconds if a PR is an easy merge or a 5 minute phone call.

If you are struggling with PR reviews, this is a sign that something is wrong with the coal mine, not with your birds.

Re:GitHub New pull request overview page in public preview by ncruces on Sunday November 08, 2026 @04:43AM (#50411763)
> I can recognize within seconds if a PR is an easy merge or a 5 minute phone call.

I'm glad you can.

Even before agents, I'm pulled to work on at least a couple different projects a year, the successful ones with teams of 10s of people working on them. If I stay longer than a couple of months, I eventually become the expert on some of the things I did, so I get pulled years later to review something I haven't touched in ages, which has changed requirements and grown a bunch of dependents.

That was the reality of working on a team with hundreds of people and dozens of related products.

Now agents are “helping” people increase complexity and velocity 10-fold.

You can call it a problem in the coal mine, but there's no going back. GitHub simply has no choice but to handle this new scale.

Re:GitHub New pull request overview page in public preview by ludwik on Sunday November 08, 2026 @05:05AM (#50411874)
> I can recognize within seconds if a PR is an easy merge or a 5 minute phone call

I could, before LLM-authored PRs. They broke all my heuristics for what to check. LLMs can write code that looks incredibly professional and well thought out, and nowadays they almost never make the usual human mistakes (like off-by-one errors). But at the same time, they can make incredibly silly mistakes of the kind people would never make (like inventing brand-new parameters for some remote API call).

It feels like everything I’ve learned over the years about reviewing code no longer applies.

Re:GitHub New pull request overview page in public preview by thebrain on Sunday November 08, 2026 @08:33AM (#50413207)
I used to be able to say the same but 10k loc diffs at my org shattered this ability pretty quickly.
Re:GitHub New pull request overview page in public preview by xyzsparetimexyz on Sunday November 08, 2026 @08:42AM (#50413289)
auto reject, ask to split it up and minimize the diff.