Re:GitHub New pull request overview page in public preview
by jayknight on Saturday November 07, 2026 @08:42PM
(#50409766)
I mean if it's a code review, you gotta review the code.
[ Parent
| on HN ]
Re:GitHub New pull request overview page in public preview
by johannes1234321 on Saturday November 07, 2026 @08:50PM
(#50409798)
Yes, but code can be presented in different ways. This depends of course to a degree on the submitter (large changeset touching a lot of files or smaller change sets building upon each other?) but also could be presented differently (highlighting changes to data structures, identifying core parts of code and helper routines - lots of room for imagination)
Also mind: one doesn't only have to review changes code, but also review what hasn't been changed (are preconditions of other code still met?)
Re:GitHub New pull request overview page in public preview
by karakrakow on Saturday November 07, 2026 @09:41PM
(#50409996)
I've been trying to auto generate diagrams on PRs I'm reviewing. Flows changes via sequence diagrams, state changes and schema changes, post it to the PR with a skill. Then look at the relevant code based on the diagrams. Then \code-reviews. Moderately helpful. YMMV