And while I hope, really hope that people will figure it out based on what information they get back from first time using the search box, I somehow doubt the majority of people will realize that the information is actually based on what they themselves wrote in the box and thus someone now has a record of it. A large portion of people dont even figure this out when using search on the Internet. Maybe that's a bit pessimistic, and its only a small fraction of people that do not know that every word they type in Google and Facebook is saved for all eternity. The data I can gather from observing people I see around me however, sadly support the more pessimistic view.
How heinous you view this act depends on how much you value your data, I suppose, but I think the analogy quite accurately describes Stallman's feelings on the matter and is thus an apt analogy for him to use in an article. It may not represent your feelings on the matter. It would be more productive to dispute why you think Canonical's actions are not a breach of privacy or not offensive to you rather than taking exception to his analogy.
The 'poisonous food' analogy isn't quite right, because it's not as simple as selling something bad as something good. Done right, remote search results could be a useful feature, it's just not the feature many of us would expect in that place.