News for hackers. Stuff that matters.
Re:Carrot Disclosure: Forgejo by martey on Tuesday April 28, 2026 @08:11PM (#47942586)
While I agree with you that this blog post (and the "carrot disclosure" described in it) is ill-considered, the pull request is not really "new code", it adds quotes to HTML attributes that are missing them. I think it's entirely reasonable for a contributor to assume that a new test case would not be needed for this small change, and that the maintainer's response ("So a simple question: is this code covered under a test? If not, you will have to add one.") is more abrasive than necessary.
Re:Carrot Disclosure: Forgejo by preisschild on Wednesday April 29, 2026 @04:39AM (#47945683)
a test is probably not the right thing for this, but adding a linting rule so that quoting is enforced everywhere is probably the right way to go