News for hackers. Stuff that matters.
Re:GitHub Stacked PRs by illamint on Monday April 13, 2026 @11:38PM (#47760971)
Good. That's the point.
Re:GitHub Stacked PRs by eru on Monday April 13, 2026 @11:45PM (#47761002)
The point of what?

I hope they fixed phabricator in the meantime.

Re:GitHub Stacked PRs by dbetteridge on Tuesday April 14, 2026 @12:23AM (#47761216)
The point is the main branch reflects the "units" of change, not the individual commits to get there.

One merged pr is a unit of change, at the end of the day the steps you took to produce it aren't relevant to others.

My opinion of course, I'm open to understanding why preserving individual commits is beneficial

Re:GitHub Stacked PRs by eru on Tuesday April 14, 2026 @01:12AM (#47761491)
You can get what you want from `git log --first-parent` without having to toss out information.

See how the Linux kernel handles git history to see a good example of non-linear history and where it helps. They use merge commits, ie commits with more than one ancestor, all the time.

Re:GitHub Stacked PRs by saagarjha on Tuesday April 14, 2026 @08:36AM (#47764848)
A unit of change is a commit. I have no idea why you'd think a PR is a unit of change.
Re:GitHub Stacked PRs by zip1234 on Tuesday April 14, 2026 @09:09AM (#47765196)
Does your org approve specific commits or PRs overall?
Re:GitHub Stacked PRs by saagarjha on Tuesday April 14, 2026 @10:05AM (#47765826)
PRs. This is largely why we don't do stacked PRs: they can just be a chain of commits in one PR
Re:GitHub Stacked PRs by eru on Tuesday April 14, 2026 @11:43PM (#47774453)
Looking at individual commits is part of the PR review process.