News for hackers. Stuff that matters.
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by rwmj on Wednesday March 18, 2026 @01:39PM (#47428782)
Better to link to the site itself, or one of the reviews?

For an example of a review (picked pretty much at random) see: https://sashiko.dev/#/patchset/20260318151256.2590375-1-andr...

The original patch series corresponding to that is: https://lkml.org/lkml/2026/3/18/1600

Edit: Here's a simpler and better example of a review: https://sashiko.dev/#/patchset/20260318110848.2779003-1-liju...

I'm very glad they're not spamming the mailing list.

Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by jeffbee on Wednesday March 18, 2026 @01:48PM (#47428908)
That is both really useful and a great example of why they should have stopped writing code in C decades ago. So many kernel bugs have arisen from people adding early returns without thinking about the cleanup functions, a problem that many other language platforms handle automatically on scope exit.
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by overfeed on Wednesday March 18, 2026 @02:34PM (#47429580)
Must we do this on every thread about the Linux kernel?
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by RobRivera on Wednesday March 18, 2026 @04:25PM (#47430976)
The beatings will continue until morale improves
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by vpShane on Wednesday March 18, 2026 @05:45PM (#47431814)
yeah but Linux is love, linux is life. if you really want to get the beatings going:

Rust > C and GNU/Linux should be Rust.

Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by ugh123 on Wednesday March 18, 2026 @06:50PM (#47432393)
also vim > emacs
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by Ferret7446 on Wednesday March 18, 2026 @11:08PM (#47434416)
Ironically C is safer than Rust (if you compile it with Fil-C)
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by tigen on Wednesday March 18, 2026 @03:43PM (#47430493)
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by nurettin on Wednesday March 18, 2026 @04:40PM (#47431160)
> stopped writing code in C decades ago.

And what were they supposed to use in 2006? Free Pascal? Ada?

Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by greenavocado on Wednesday March 18, 2026 @04:53PM (#47431316)
Someone suggested C++ and you should see the response from Linus

https://harmful.cat-v.org/software/c++/linus

Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by nurettin on Wednesday March 18, 2026 @07:10PM (#47432543)
Of course I specifically avoided invoking that language's name within the context of kernel programming in fear of summoning a Linus.

And he's so right. I didn't think like that back then, but new/delete (which have to be overloaded for kernel) behind allocators behind containers, vtables, =0, uninitialized members, unhandled ctor errors, template magic, "sometimes rvo", compiler hints, "sometimes reinterpret cast", 3rd party libraries, it would have been a disaster 20 years ago. Now he's being nice to Rust partially to spite that lang I love some more.

Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by KurSix on Thursday March 19, 2026 @03:59AM (#47436236)
You don't even need an LLM for this stuff. GCC has the __cleanup__ attribute, and kernel static analyzers like Smatch have been catching missing unlocks for a decade now. People just ignore linter warnings when submitting patches, so the language itself isn't really the issue. The LLM is basically just acting as a talking linter that can explain the error in plain English
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by jeffbee on Thursday March 19, 2026 @03:03PM (#47444253)
Linux doesn't have any of: sufficient testing, sufficient static analysis, or sufficient pre-commit code review. Under those conditions, which I take as a given because it's their project and we can't just swap out the leaders with more tasteful leaders, adding this type of third-party review feedback strikes me as valuable. Perhaps, to your point, it would also be possible to simply run static analyzers on new proposed commits.
Re:Google Engineers Launch "Sashiko" for Agentic AI Code Rev... by pvtmert on Sunday March 22, 2026 @08:16AM (#47476730)
To be honest, during my ~10 years of experience, I haven't stumbled on any _project_ that has _sufficient_ amount of either testing, static analysis, and/or, where everyone who contributes gives a damn about linter/formatter warnings or errors.

Unless there is a CI that fails immediately when these checks fail, and it is not possible to bypass/override, then of course quality in the codebase improves significantly.

But that is very hard to give business results, in terms of ROI, 99.9% of the PMs will sweep these under the rug, because of unclear ROI.

Another remark I have to make is that, these things should be in a cloud/container (isolated environment) somewhere. Because I know several people who has their git commit aliased with no-precommit-hooks, because well, otherwise they complain that it is too slow. (Slowness is another issue that can be improved, but again, less visible ROI than just adding the command-line switch)