Well they shared the iron dome schematics with the U.S. (as part of an agreement where U.S. partially funded it)

Israel has provided lots of other services to the U.S. Its pharma company Teva probably produces more generic medications in the U.S. than any other pharma companies (I imagine for a significant number of these, the brand-name trademark would be held in Russia or China)

They provide training to American police.

They provide a place for military tech contractors to field-test their surveillance and murder technology against a captive population

They provide software which aids the U.S. own surveillance and privacy violation of its citizens (Cellbrite and Pegasus for example)

The alliance isn't always amicable; Israel has hacked the U.S. government before to get confidential information, and there is an argument that they collect dirt on influential people such as politicians to ensure their loyalty. At the very least, they provide a way for U.S. lawmakers in their good graces to receive additional sources of funding (through PACs), in exchange for occasional diversion of public funds to them.

They also serve as a foothold into the middle-east for the U.S. to exert political pressure on nearby countries, and provide "diplomatic" avenues to protect their access to oil reserves (including those in Palestine, such as the Chevron-owned, and currently inactive, Mari B oil field off the coast of Gaza)

Everything on your list involved the sale of a product, by this logic China would be our closest ally (actually I wish our leaders were that sane, but the inconsistency stands...).

I wish people could just state the transparently documented historical truth, Israel is a US ally because Truman and enough other backers wanted to create a state for Holocaust survivors. The leadership and majority of voters in the US have been true believers in Zionism (in one of its many versions) for generations, and supports Israel by essentially the same logic that Israelis support Israel by. This existed as a state of affairs with almost no opposition at any level until a couple years ago when it came into conflict with another basic belief (about being close enough to just in the cause and method of war that most people could somewhat believe it).

Heaps of military and intelligence technology, base of operations / bastion in the middle east, etc.