Re:Sj.h: A tiny little JSON parsing library in ~150 lines of...
by stevepotter on Monday September 22, 2025 @07:07AM
(#45331781)
I understand your point and if I were the author I would want either a disclaimer or a fix. File an issue or make a pr. Filing an issue is quicker and more fruitful than dealing with folks here
In the present case, either the UB in the code is by mistake or lack of awareness, and then it's warranted to point out the error, or, as GGGP argued, the author deliberately decided to neglect safety or correctness, and then in my opinion you can't reject the criticism as unwarranted if the project's presentation isn't explicit about that.
I'm not making anything the author's problem here. Rather, I'm defending my criticism of the code, and am giving arguments as to why it would be good form to make it explicit if a project doesn't care about the code being safe and correct.