News for hackers. Stuff that matters.
Re:Introducing Malicious Code Reviews by tptacek on Monday January 26, 2009 @05:05PM (#451143)
The best you can come up with is how tangled the code in a hand-written lexer looks? I may have skimmed a bit towards the end, but, did you actually find a bug?
Re:Introducing Malicious Code Reviews by huhtenberg on Monday January 26, 2009 @06:57PM (#451305)
That code is really bad. Dunno about you, but to me this handcrafted entanglement looks like the crap that any professional programmer should be ashamed of:

  if ( .. )
  {
     for ( .. )
     {
  label:
        ...
     }
  }
  else
  {
     if ( .. )
     {
       ..
     }
     else
       goto label;
     ..
   }
The actual code is even worse than this as there's a second goto that jumps from the top for into one of else blocks at the bottom from where the control can go back to for via another goto ... I sort of can see how this code came about, but there is absolutely no excuse for checking in something this f*cked up.

If they wanted to show off, they should've just used the coroutines :-)

Re:Introducing Malicious Code Reviews by coliveira on Monday January 26, 2009 @10:31PM (#451573)
It has been explained that this is just a way of implementing a fast lexical scanner. This is the kind of code that you don't come up with, it is a mechanical implementation of a state machine.
Re:Introducing Malicious Code Reviews by huhtenberg on Monday January 26, 2009 @11:57PM (#451676)
Mechanical or not, this is a very untidy way of implementing a "fast lexical scanner". Even the Duff's device looks cleaner and more elegant in comparison. And it's not like there is a shortage of other implementation options that are as fast.
Re:Introducing Malicious Code Reviews by mindviews on Monday January 26, 2009 @05:26PM (#451188)
Didn't look like he pointed out any bugs - but that's not really the main point of a code review. It's all well and good for the compiler to understand the code and have it execute properly, but is it human-readable? Or maintainable? Having looked at the source file, I'd say that particular method is neither.
Re:Introducing Malicious Code Reviews by pbiggar on Monday January 26, 2009 @05:09PM (#451148)
Since its practically the entire contents of the file, its hard to do better.

As to the presence of a bug, impossible to tell. Which is the point.

Re:Introducing Malicious Code Reviews by tptacek on Monday January 26, 2009 @05:22PM (#451178)
So, I do a lot of code review --- a job hazard --- and we tend to score them based on whether we find anything. You may want to find a softer target.