Re:Why I'm declining your AI generated MR
by thekevan on Tuesday August 26, 2025 @07:00PM
(#45033383)
We get it, some changes to a project are a bad idea. I feel like the overemphasis on AI generated ones is kind of posturing.
[ Parent
| on HN ]
I got a MR the other day that should be 40 lines of code but it was 1000. It "mostly" worked. Do I pick apart this slop? Why should I? It's bad for the team and for the project.
It's hard to respond to that. I'm genuinely stumped. As I explain in the post, this is me trying to write something re-usable to share with people who do that to a team lead.
Re:Why I'm declining your AI generated MR
by thekevan on Wednesday August 27, 2025 @12:04PM
(#45041499)
"I got a MR the other day that should be 40 lines of code but it was 1000. It "mostly" worked."
I mean just stop there. It isn't a good MR.
Re:Why I'm declining your AI generated MR
by zulban on Wednesday August 27, 2025 @12:32PM
(#45041855)
I think you're missing the point.
If I give a fun extreme example it doesn't mean there's no subtle problem. Where do you draw the line? Maybe I guessed 40 but it would really be 80. Maybe they send in 400 lines. 200?
Also 1000 is maybe fine if it's a one shot script that just works one time on non-prod.