Code Review Can Be Better

Re:Code Review Can Be Better by MutedEstate45 on Wednesday August 20, 2025 @08:48PM (#44968015)

Agree with your pain points. One thing id add is GitHub makes you reapprove every PR after each push. As an OSS contributor it’s exhausting to chase re-approvals for minor tweaks.

[ Parent | on HN ]

Re:Code Review Can Be Better by irjustin on Wednesday August 20, 2025 @08:52PM (#44968034)

mmmm this is up to each repo/maintainer's settings.

To be fair you don't know if one line change is going to absolutely compromise a flow. OSS needs to maintain a level of disconnect to be safe vs fast.

[ Parent | on HN ]

Re:Code Review Can Be Better by MutedEstate45 on Wednesday August 20, 2025 @09:52PM (#44968308)

Good to know! Never been a maintainer before so I thought that was required.

[ Parent | on HN ]

Re:Code Review Can Be Better by o11c on Thursday August 21, 2025 @12:58AM (#44969171)

Adding fixup commits (specifying the specific commit they will be squashed into), to be squashed by the bot before merge, handles that.

[ Parent | on HN ]

Re:Code Review Can Be Better by pie_flavor on Wednesday August 20, 2025 @08:51PM (#44968031)

This is a security setting that the author has chosen to enable.

[ Parent | on HN ]

Re:Code Review Can Be Better by Ar-Curunir on Wednesday August 20, 2025 @08:51PM (#44968030)

Hm that’s not the case for my repositories? Maybe you have a setting enabled for that?

[ Parent | on HN ]