College algebra isn't something that a lot of math, science and engineering majors take, especially if they're toward the top of the class and haven't taken the easy road in their high school course selections.
What do you mean x^2+1 is prime ? For me prime only applies to integers or do I miss another way this word is used ?
I don't know the French education system but it would be very shocking to me if the discriminant is taught when factoring is first taught. Factoring x^3 - y^3 does not have anything to do with the discriminant and x^3 - y^3 is typically taught when factoring is first introduced. At least in the U.S.
In the integers, 1 and -1 are units. So 7 is prime even though it can be "factored" as 7 = 7(-1)(-1) or 7 = (7)(1). Likewise, 4n^2 + 4n + 2 is prime, even though it can be "factored" as (2)(2n^2 + 2n + 1).
Also, your method of substituting a variable is suspect. Being irreducible is a property of a particular polynomial; if you substitute a different expression for x and simplify, you have a different polynomial. Your argument is like saying, "7 is prime, but if you add three to it, it becomes 10 which isn't prime, how can this be?" -- you did something to the number 7 which turned it into a different number, so it should be no surprise that its properties may have changed in the process.
If you want to know about polynomial factorization over various fields, any good abstract algebra textbook should discuss the topic at great length.
Presently it is standard to introduce factoring before one knows how to graph polynomial functions. It is possible to argue that we teach this before factoring and I think a compelling case can be made for this but it isn't a standard practice. Anyone who thinks of using x-intercepts to explain this probably has had some College Algebra. The topic in the article is usually covered in Beginning Algebra.
References to the discriminant in criticizing the article are not appropriate. The discriminant is taught after teaching factoring.
The normal order of topics is
1. factoring 2. solving quadratic equations with factoring 3. proving the quadratic formula 4. solving general quadratic equations