Re:Cmapv2: A high performance, concurrent map
by johnisgood on Wednesday June 18, 2025 @07:59AM
(#44309104)
So, what are the solutions if they are indeed not safe to do read / write concurrently?
Like okay, I read "both []byte slices, which are not safe for concurrent r/w access", but then, what is the solution? If the claim is indeed true.
Re:Cmapv2: A high performance, concurrent map
by sapiogram on Wednesday June 18, 2025 @12:36PM
(#44311341)
Some options:
- Make sure no one mutates the slice ever, making it safe to read
- Guarding the slice behind a mutex, requiring anyone who reads or writes it to lock the mutex first
- Using some kind of thread-safe slice implementation
Re:Cmapv2: A high performance, concurrent map
by sirgallo on Wednesday June 18, 2025 @12:47PM
(#44311424)
I went with option 1.
On a mutation, I do a complete node copy where I also copy the key/value slices. When I set a child node for the first time or update a child, I create a branch new leaf node with a copy of the key/value. This way previous nodes maintain the original copy.
I haven't looked at the code, but that doesn't make sense to me. If you can't read the slice safely, you also can't clone it safely.