News for hackers. Stuff that matters.
Re:Show HN - Github competitor with free private repo by arthurschreiber on Friday August 24, 2012 @06:37PM (#4430040)
Hah! Your pull request actually introduces subtle bugs into the diff view. I had already submitted _exactly_ the same change some months ago, and after having it enabled for some time in our gitlab installation at work, I ran into some issues.

I can't remember the exact preconditions, but there were cases where this change would start showing changes that were not even part of the merge request at all, which was extremely confusing.

In the end, I went ahead and did some more low-level changes to gitlab, so it would not only save the branch for a merge request, but it would save the actual commit shas of the source revision. That was much more accurate and reflects the way pull requests work on Github.

Re:Show HN - Github competitor with free private repo by sytse on Saturday August 25, 2012 @03:37AM (#4431372)
Thank you for the warning. Do you have a test case that reproduces the problem that you can share?