Re:Why I am tired of writing pull requests
by mirsadm on Thursday August 23, 2012 @10:04PM
(#4425866)
I always figured the unwritten rule for every developer is to always follow the existing code's style regardless of their own opinion of it.
[ Parent
| on HN ]
Re:Why I am tired of writing pull requests
by josegonzalez on Thursday August 23, 2012 @10:16PM
(#4425901)
That's not always the case, and sometimes if you don't know the language very well - in my case, Ruby - then certain patterns aren't available to you and it looks hokey without you realizing it.
Completely forgivable. This pull request[0], on the other hand, is probably more along the lines of what mirsadm was thinking of.
[0]: https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...
Re:Why I am tired of writing pull requests
by masklinn on Friday August 24, 2012 @03:56AM
(#4426691)
That's the douchiest diff I've seen yet. I've seen diffs where a shitty and misconfigured IDE had reformatted half the code and the guy hadn't reviewed his diff, but "incidentally spaces to tab" is the biggest "fuck you reviewer" I can think of.
I have no clue where that commit is coming from. How do I get to it? Thanks.
Re:Why I am tired of writing pull requests
by tedunangst on Friday August 24, 2012 @11:15AM
(#4427955)
It's the same commit you linked to, but ignoring whitespace changes (&w=1, like diff -w).