You might want to stop running atop

Re:You might want to stop running atop by isotopp on Wednesday March 26, 2025 @04:49AM (#43480117)

Eh? Calling system() for a binary without a path? And why system() using execl() in the first place, when you could do something using execve() without a sh inbetween instead?

Even w/o an exploit this can be prettier and more secure.

[ Parent | on HN ]

Re:You might want to stop running atop by TheDong on Wednesday March 26, 2025 @05:39AM (#43480382)

We're not disagreeing. Even if there's no 'sploit there, people have spaces in their directory or file names, and it's kinda nice for your tool to work with those, so obviously you should be using an execve variant to pass arguments properly.

I assume the reason for the incorrect system call is that doing a shell redirect ('>') does actually look prettier though.

Doing the actual right code is definitely less pretty looking IMO: https://github.com/luvit/zlib/blob/8de57bce969eb9dafc1f1f5c2...

[ Parent | on HN ]